Re: [PATCH 4/4] iio: adc: ina2xx: Use label proper for device identification

[Michal Simek]

On 27. 08. 19 5:55, Phil Reid wrote:
> On 26/08/2019 02:07, Jonathan Cameron wrote:
>> On Wed, 21 Aug 2019 11:12:00 +0200
>> Michal Simek <michal.simek@xxxxxxxxxx> wrote:
>>
>>> On 21. 08. 19 4:11, Phil Reid wrote:
>>>> On 20/08/2019 22:11, Michal Simek wrote:
>>>>> Add support for using label property for easier device
>>>>> identification via
>>>>> iio framework.
>>>>>
>>>>> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
>>>>> ---
>>>>>
>>>>> ÂÂ drivers/iio/adc/ina2xx-adc.c | 2 +-
>>>>> ÂÂ 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/iio/adc/ina2xx-adc.c
>>>>> b/drivers/iio/adc/ina2xx-adc.c
>>>>> index 7c7c63677bf4..077c54915f70 100644
>>>>> --- a/drivers/iio/adc/ina2xx-adc.c
>>>>> +++ b/drivers/iio/adc/ina2xx-adc.c
>>>>> @@ -1033,7 +1033,7 @@ static int ina2xx_probe(struct i2c_client
>>>>> *client,
>>>>> ÂÂÂÂÂÂ snprintf(chip->name, sizeof(chip->name), "%s-%s",
>>>>> ÂÂÂÂÂÂÂÂÂÂÂ client->name, dev_name(&client->dev));
>>>>> ÂÂ -ÂÂÂ indio_dev->name = chip->name;
>>>>> +ÂÂÂ indio_dev->name = of_get_property(np, "label", NULL) ? :
>>>>> chip->name;
>>>>> ÂÂÂÂÂÂ indio_dev->setup_ops = &ina2xx_setup_ops;
>>>>> ÂÂ ÂÂÂÂÂ buffer = devm_iio_kfifo_allocate(&indio_dev->dev);
>>>>> Â 
>>>> I like this personally. It'd be nice if it was a core function so
>>>> it could be an opt in to any iio device.
>>>>
>>>> Don't know how well received that'd be thou.
>>>> ÂÂ 
>> I'm not particularly keen on changing the semantics of existing
>> ABI, but how about adding new ABI to provide this?
>>
>> /sys/bus/iio/devices/iio\:device0/label for example?
>>
>> I haven't thought about it in depth yet though. If you spin
>> a patch with that and the DT docs we'll be more likely to get
>> a view from DT maintainers if this is acceptable use of label.
>>
> 
> I've sent "iio: core: Add optional symbolic label to device attributes"
> for further discussion.

Series looks good. I expect that there will be also update in libiio if
this is accepted.

Thanks,
Michal