Re: [patch V2 38/38] posix-cpu-timers: Utilize timerqueue for storage

From: Thomas Gleixner
Date: Tue Aug 27 2019 - 09:46:07 EST


On Tue, 27 Aug 2019, Frederic Weisbecker wrote:
> On Tue, Aug 27, 2019 at 08:08:06AM +0200, Thomas Gleixner wrote:
> > On Tue, 27 Aug 2019, Frederic Weisbecker wrote:
> >
> > > On Wed, Aug 21, 2019 at 09:09:25PM +0200, Thomas Gleixner wrote:
> > > > /**
> > > > @@ -92,14 +130,10 @@ struct posix_cputimers {
> > > >
> > > > static inline void posix_cputimers_init(struct posix_cputimers *pct)
> > > > {
> > > > - pct->timers_active = 0;
> > > > - pct->expiry_active = 0;
> > >
> > > No more need to initialize these?
> > >
> > > > + memset(pct->bases, 0, sizeof(pct->bases));
> >
> > memset() does that IIRC :)
>
> But those two fields aren't part of pct->bases, are they? :)

Duh. I wanted to memset() the full pile obviously.