Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

From: Harry Wentland
Date: Tue Aug 27 2019 - 10:01:33 EST


On 2019-08-27 3:09 a.m., YueHaibing wrote:
> After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"),
> there is no caller in tree.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx>

Harry

> ---
> .../drm/amd/display/modules/info_packet/info_packet.c | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> index 5f4b98d..d885d64 100644
> --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> @@ -114,25 +114,6 @@ enum ColorimetryYCCDP {
> ColorimetryYCC_DP_ITU2020YCbCr = 7,
> };
>
> -void setFieldWithMask(unsigned char *dest, unsigned int mask, unsigned int value)
> -{
> - unsigned int shift = 0;
> -
> - if (!mask || !dest)
> - return;
> -
> - while (!((mask >> shift) & 1))
> - shift++;
> -
> - //reset
> - *dest = *dest & ~mask;
> - //set
> - //dont let value span past mask
> - value = value & (mask >> shift);
> - //insert value
> - *dest = *dest | (value << shift);
> -}
> -
> void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
> struct dc_info_packet *info_packet)
> {
>