RE: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

[Othman, Ahmad]

Hi Alex,

There are callers in the same file "info_packet.c" 

-----Original Message-----
From: Alex Deucher <alexdeucher@xxxxxxxxx> 
Sent: August 27, 2019 10:20
To: Wentland, Harry <Harry.Wentland@xxxxxxx>
Cc: YueHaibing <yuehaibing@xxxxxxxxxx>; Wentland, Harry <Harry.Wentland@xxxxxxx>; Li, Sun peng (Leo) <Sunpeng.Li@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx>; Zhou, David(ChunMing) <David1.Zhou@xxxxxxx>; airlied@xxxxxxxx; daniel@xxxxxxxx; Lakha, Bhawanpreet <Bhawanpreet.Lakha@xxxxxxx>; Koo, Anthony <Anthony.Koo@xxxxxxx>; Othman, Ahmad <Ahmad.Othman@xxxxxxx>; Bernstein, Eric <Eric.Bernstein@xxxxxxx>; Cyr, Aric <Aric.Cyr@xxxxxxx>; alvin.lee3@xxxxxxx; Tatla, Harmanprit <Harmanprit.Tatla@xxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

On Tue, Aug 27, 2019 at 10:01 AM Harry Wentland <hwentlan@xxxxxxx> wrote:
>
> On 2019-08-27 3:09 a.m., YueHaibing wrote:
> > After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"), 
> > there is no caller in tree.
> >
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> Signed-off-by: 
> > YueHaibing <yuehaibing@xxxxxxxxxx>
>
> Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx>
>

Applied.  Thanks!

Alex

> Harry
>
> > ---
> >  .../drm/amd/display/modules/info_packet/info_packet.c | 19 
> > -------------------
> >  1 file changed, 19 deletions(-)
> >
> > diff --git 
> > a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c 
> > b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > index 5f4b98d..d885d64 100644
> > --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > @@ -114,25 +114,6 @@ enum ColorimetryYCCDP {
> >       ColorimetryYCC_DP_ITU2020YCbCr  = 7,  };
> >
> > -void setFieldWithMask(unsigned char *dest, unsigned int mask, 
> > unsigned int value) -{
> > -     unsigned int shift = 0;
> > -
> > -     if (!mask || !dest)
> > -             return;
> > -
> > -     while (!((mask >> shift) & 1))
> > -             shift++;
> > -
> > -     //reset
> > -     *dest = *dest & ~mask;
> > -     //set
> > -     //dont let value span past mask
> > -     value = value & (mask >> shift);
> > -     //insert value
> > -     *dest = *dest | (value << shift);
> > -}
> > -
> >  void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
> >               struct dc_info_packet *info_packet)  {
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx