Re: [PATCH] rtc: pcf2127: bugfix: watchdog build dependency

From: Alexandre Belloni
Date: Tue Aug 27 2019 - 12:26:19 EST


On 27/08/2019 16:36:56+0200, Bruno Thomsen wrote:
> Disable watchdog registation when kernel is build without
> watchdog functionality, and enable watchdog core otherwise.
> This removes compile errors like the one below:
>
> drivers/rtc/rtc-pcf2127.o: in function `pcf2127_probe.constprop.3':
> rtc-pcf2127.c:(.text.unlikely+0x2c8): undefined reference to
> `devm_watchdog_register_device'
>
> Watchdog feature in chip will always be configured as
> this is safe to do in both cases and minimize code churn.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Reported-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> Fixes: bbc597561ce1 ("rtc: pcf2127: add watchdog feature support")
> Signed-off-by: Bruno Thomsen <bruno.thomsen@xxxxxxxxx>
> ---
> drivers/rtc/Kconfig | 1 +
> drivers/rtc/rtc-pcf2127.c | 2 ++
> 2 files changed, 3 insertions(+)
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com