Re: [PATCH v2 1/4] x86/vmware: Update platform detection code for VMCALL/VMMCALL hypercalls

From: Borislav Petkov
Date: Tue Aug 27 2019 - 15:48:15 EST


On Tue, Aug 27, 2019 at 09:19:54PM +0200, Thomas HellstrÃm (VMware) wrote:
> We *do* have checkpatch.pl in the workflow. In this case I figured the
> warnings actually didn't make sense. There are breaks present and
> -Wimplicit-fallthrough doesn't complain...

Oh, we have enabled that by default already:

a035d552a93b ("Makefile: Globally enable fall-through warning")

I guess checkpatch wrongly complains here and I did trust its output
blindly. That ain't happening again, sorry about that.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.