Re: [PATCH v5 2/4] iio: imu: st_lsm6sdx: move register definitions to sensor_settings struct

From: Jonathan Cameron
Date: Tue Aug 27 2019 - 15:59:33 EST


On Tue, 27 Aug 2019 08:54:57 +0200
Martin Kepplinger <martin.kepplinger@xxxxxxx> wrote:

> On 21.08.19 15:25, Martin Kepplinger wrote:
> > Move some register definitions to the per-device array of struct
> > st_lsm6dsx_sensor_settings in order to simplify adding new sensor
> > devices to the driver.
> >
> > Also, remove completely unused register definitions.
> >
> > Signed-off-by: Martin Kepplinger <martin.kepplinger@xxxxxxx>
> > Acked-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> > ---
> > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 6 ++++
> > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 31 ++++++++++++++------
> > 2 files changed, 28 insertions(+), 9 deletions(-)
> >
>
> I just notices the commit message header typo "st_lsm6sdx" should be
> "st_lsm6dsx" of course. If you can still rebase/force-push to testing,
> would you be able to fix that? If it's too far out there already, so be
> it :) sorry for the typo, and thanks for adding "-imu" yourself where
> applicable.

I can indeed. Fixed up.

Added Rob's ack to the dt patch as well.

Thanks,

Jonathan

>
> thanks,
>
> martin