Re: [alsa-devel] [RESEND PATCH v4 1/4] dt-bindings: soundwire: add slave bindings

From: Srinivas Kandagatla
Date: Tue Aug 27 2019 - 17:21:17 EST




On 26/08/2019 17:22, Pierre-Louis Bossart wrote:

+ÂÂÂÂÂ description:
+ÂÂÂÂÂ Is the textual representation of SoundWire Enumeration
+ÂÂÂÂÂ address. compatible string should contain SoundWire Version ID,
+ÂÂÂÂÂ Manufacturer ID, Part ID and Class ID in order and shall be in
+ÂÂÂÂÂ lower-case hexadecimal with leading zeroes.
+ÂÂÂÂÂ Valid sizes of these fields are
+ÂÂÂÂÂ Version ID is 1 nibble, number '0x1' represents SoundWire 1.0
+ÂÂÂÂÂ and '0x2' represents SoundWire 1.1 and so on.
+ÂÂÂÂÂ MFD is 4 nibbles
+ÂÂÂÂÂ PID is 4 nibbles
+ÂÂÂÂÂ CID is 2 nibbles
+ÂÂÂÂÂ More Information on detail of encoding of these fields can be
+ÂÂÂÂÂ found in MIPI Alliance DisCo & SoundWire 1.0 Specifications.
+
+ÂÂÂÂÂ reg:
+ÂÂÂÂÂÂÂ maxItems: 1
+ÂÂÂÂÂÂÂ description:
+ÂÂÂÂÂÂÂÂÂ Instance ID and Link ID of SoundWire Device Address.

maybe put link first and make it clear that both are required.
Okay, I will give that a go in next version!

thanks,
srini