Re: [PATCH v2] vsprintf: introduce %dE for error constants

[Uwe Kleine-KÃnig]

Hello Joe,

On 8/27/19 11:22 PM, Joe Perches wrote:
> On Tue, 2019-08-27 at 23:12 +0200, Uwe Kleine-KÃnig wrote:
>> The new format specifier %dE introduced with this patch pretty-prints
>> the typical negative error values. So
>>
>> 	pr_info("probing failed (%dE)\n", ret);
>>
>> yields
>>
>> 	probing failed (EIO)
>>
>> if ret holds -EIO. This is easier to understand than the for now common
>>
>> 	probing failed (-5)
> 
> I suggest using both outputs like '-5 -EIO'
> rather than a single string

I like it the way it is implemented as it is more flexible. If you want
to see both, you can still do

	pr_info("probing failed (%d %dE)\n", ret, ret);

and people (like me) who think that giving only EIO can still do just that.

Best regards
Uwe

Attachment: signature.asc
Description: OpenPGP digital signature