RE: [EXT] Re: [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add ls2080a compatibility string to bindings

From: Ashish Kumar
Date: Wed Aug 28 2019 - 02:20:42 EST




> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Tuesday, August 27, 2019 11:33 PM
> To: Ashish Kumar <ashish.kumar@xxxxxxx>
> Cc: shawnguo@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> spi@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx;
> mark.rutland@xxxxxxx; linux-next@xxxxxxxxxxxxxxx; Kuldeep Singh
> <kuldeep.singh@xxxxxxx>
> Subject: Re: [EXT] Re: [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add ls2080a
> compatibility string to bindings
>
> On Mon, Aug 26, 2019 at 06:19:53AM +0000, Ashish Kumar wrote:
>
> > For Patch-2, I intended to use this in arm64/boot/dts/freescale/fsl-
> ls1088a.dtsi (please see below), since both ls1088 and ls2080 has same QSPI
> controller.
> > So I had introduced new compatible
> > + "fsl,ls1012a-qspi" followed by "fsl,ls1021a-qspi"
> > + "fsl,ls1088a-qspi" followed by "fsl,ls2080a-qspi"
>
> Even if the compatible is supposed to be used in conjunction with other
> fallbacks it should still explicitly be there in case someone forgets or decides
> not to do that for some reason.
Thanks Mark, I will update the spi-fsl-qspi.c to include ls1088, ls1012 in driver data.

Regards
Ashish