Re: [PATCH v3 0/6] hugetlb_cgroup: Add hugetlb_cgroup reservation limits

From: Michal Hocko
Date: Wed Aug 28 2019 - 07:23:45 EST


On Mon 26-08-19 16:32:34, Mina Almasry wrote:
> mm/hugetlb.c | 493 ++++++++++++------
> mm/hugetlb_cgroup.c | 187 +++++--

This is a lot of changes to an already subtle code which hugetlb
reservations undoubly are. Moreover cgroupv1 is feature frozen and I am
not aware of any plans to port the controller to v2. That all doesn't
sound in favor of this change. Mike is the maintainer of the hugetlb
code so I will defer to him to make a decision but I wouldn't recommend
that.
--
Michal Hocko
SUSE Labs