Re: [PATCHv5] drivers/amba: add reset control to amba bus probe

From: Valdis KlÄtnieks
Date: Wed Aug 28 2019 - 09:46:56 EST


On Wed, 28 Aug 2019 08:34:20 -0500, Dinh Nguyen said:

> > Does this DTRT for both old and new U-Boots? My naive reading of
> > this patch
>
> What is a DTRT?

Do The Right Thing, sorry...

> > says on an old U-Boot, we end up attempting to bring it out of
> > reset even though they had already been brought out.
> >
>
> If the peripheral is already out of reset, de-asserting the reset has
> no affect.

OK, thanks. There's been hardware where doing that sort of thing twice will
confuse the device and cause issues.

Attachment: pgpjMn_Znbq8p.pgp
Description: PGP signature