Re: [PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end exports

From: Jason Gunthorpe
Date: Wed Aug 28 2019 - 10:40:32 EST


On Wed, Aug 28, 2019 at 04:21:09PM +0200, Christoph Hellwig wrote:
> Bo modular code uses these, which makes a lot of sense given the
> wrappers around them are only called by core mm code.

/Bo/No/

> Also remove the recently added __mmu_notifier_invalidate_range_start_map
> export for which the same applies.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> mm/mmu_notifier.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c
> index 690f1ea639d5..240f4e14d42e 100644
> +++ b/mm/mmu_notifier.c
> @@ -25,7 +25,6 @@ DEFINE_STATIC_SRCU(srcu);
> struct lockdep_map __mmu_notifier_invalidate_range_start_map = {
> .name = "mmu_notifier_invalidate_range_start"
> };
> -EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range_start_map);
> #endif

I inlined this hunk into Daniel's patch from yesterday

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>

Applied to hmm.git..

What about:

EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range);

elixir suggest this is not called outside mm/ either?

Jason