Re: [PATCH] lkdtm/bugs: fix build error in lkdtm_EXHAUST_STACK

[Kees Cook]

On Tue, Aug 27, 2019 at 10:44:13AM -0600, Raul E Rangel wrote:
> Building an x86 64 bit kernel:
> 
> lkdtm/bugs.c:94:2: error: format '%d' expects argument of type 'int', but argument 2 has type 'long unsigned int' [-Werror=format=]
>   pr_info("Calling function with %d frame size to depth %d ...\n",
>   ^
> 
> Fixes: 24cccab42c419 ("lkdtm/bugs: Adjust recursion test to avoid elision")
> 
> Signed-off-by: Raul E Rangel <rrangel@xxxxxxxxxxxx>

Ah yes; thanks! I should build with W=1 more often. :)

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

Greg, can you take this into drivers/misc please?

-Kees

> ---
> 
>  drivers/misc/lkdtm/bugs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/lkdtm/bugs.c b/drivers/misc/lkdtm/bugs.c
> index 1606658b9b7e..bf945704f21a 100644
> --- a/drivers/misc/lkdtm/bugs.c
> +++ b/drivers/misc/lkdtm/bugs.c
> @@ -91,7 +91,7 @@ void lkdtm_LOOP(void)
>  
>  void lkdtm_EXHAUST_STACK(void)
>  {
> -	pr_info("Calling function with %d frame size to depth %d ...\n",
> +	pr_info("Calling function with %lu frame size to depth %d ...\n",
>  		REC_STACK_SIZE, recur_count);
>  	recursive_loop(recur_count);
>  	pr_info("FAIL: survived without exhausting stack?!\n");
> -- 
> 2.23.0.187.g17f5b7556c-goog
> 

-- 
Kees Cook