Re: mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c)

From: Pierre-Louis Bossart
Date: Wed Aug 28 2019 - 15:28:08 EST

Next message: Valdis KlÄtnieks: "Re: next-20190826 - objtool fails to build."
Previous message: Uwe Kleine-KÃnig: "Re: [PATCH v2] vsprintf: introduce %dE for error constants"
In reply to: Randy Dunlap: "Re: mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c)"
Next in thread: Randy Dunlap: "Re: mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 8/28/19 1:30 PM, Randy Dunlap wrote:

On 8/27/19 8:40 PM, akpm@xxxxxxxxxxxxxxxxxxxx wrote:

The mm-of-the-moment snapshot 2019-08-27-20-39 has been uploaded to

http://www.ozlabs.org/~akpm/mmotm/

mmotm-readme.txt says

README for mm-of-the-moment:

http://www.ozlabs.org/~akpm/mmotm/

This is a snapshot of my -mm patch queue. Uploaded at random hopefully
more than once a week.

You will need quilt to apply these patches to the latest Linus release (5.x
or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
http://ozlabs.org/~akpm/mmotm/series

The file broken-out.tar.gz contains two datestamp files: .DATE and
.DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-ss,
followed by the base kernel version against which this patch series is to
be applied.

(from linux-next tree, but problem found/seen in mmotm)

Sorry, I don't know who is responsible for this driver.

That would be me.

I just checked with Mark Brown's for-next tree 8aceffa09b4b9867153bfe0ff6f40517240cee12
and things are fine in i386 mode, see below.

next-20190828 also works fine for me in i386 mode.

if you can point me to a tree and configuration that don't work I'll look into this, I'd need more info to progress.

make ARCH=i386
Using /data/pbossart/ktest/broonie-next as source for kernel
GEN Makefile
CALL /data/pbossart/ktest/broonie-next/scripts/checksyscalls.sh
CALL /data/pbossart/ktest/broonie-next/scripts/atomic/check-atomics.sh
CHK include/generated/compile.h
CC [M] sound/hda/ext/hdac_ext_bus.o
CC [M] sound/hda/ext/hdac_ext_controller.o
CC [M] sound/hda/ext/hdac_ext_stream.o
LD [M] sound/hda/ext/snd-hda-ext-core.o
CC [M] sound/hda/hda_bus_type.o
CC [M] sound/hda/hdac_bus.o
CC [M] sound/hda/hdac_device.o
CC [M] sound/hda/hdac_sysfs.o
CC [M] sound/hda/hdac_regmap.o
CC [M] sound/hda/hdac_controller.o
CC [M] sound/hda/hdac_stream.o
CC [M] sound/hda/array.o
CC [M] sound/hda/hdmi_chmap.o
CC [M] sound/hda/trace.o
CC [M] sound/hda/hdac_component.o
CC [M] sound/hda/hdac_i915.o
LD [M] sound/hda/snd-hda-core.o
CC [M] sound/hda/intel-nhlt.o
LD [M] sound/hda/snd-intel-nhlt.o
Kernel: arch/x86/boot/bzImage is ready (#18)
Building modules, stage 2.
MODPOST 156 modules
CC sound/hda/ext/snd-hda-ext-core.mod.o
LD [M] sound/hda/ext/snd-hda-ext-core.ko
CC sound/hda/snd-hda-core.mod.o
LD [M] sound/hda/snd-hda-core.ko
CC sound/hda/snd-intel-nhlt.mod.o
LD [M] sound/hda/snd-intel-nhlt.ko

~~~~~~~~~~~~~~~~~~~~~~
on i386:

CC sound/hda/intel-nhlt.o
../sound/hda/intel-nhlt.c:14:25: error: redefinition of âintel_nhlt_initâ
struct nhlt_acpi_table *intel_nhlt_init(struct device *dev)
^~~~~~~~~~~~~~~
In file included from ../sound/hda/intel-nhlt.c:5:0:
../include/sound/intel-nhlt.h:134:39: note: previous definition of âintel_nhlt_initâ was here
static inline struct nhlt_acpi_table *intel_nhlt_init(struct device *dev)
^~~~~~~~~~~~~~~
../sound/hda/intel-nhlt.c: In function âintel_nhlt_initâ:
../sound/hda/intel-nhlt.c:39:14: error: dereferencing pointer to incomplete type âstruct nhlt_resource_descâ
if (nhlt_ptr->length)
^~
../sound/hda/intel-nhlt.c:41:4: error: implicit declaration of function âmemremapâ; did you mean âioremapâ? [-Werror=implicit-function-declaration]
memremap(nhlt_ptr->min_addr, nhlt_ptr->length,
^~~~~~~~
ioremap
../sound/hda/intel-nhlt.c:42:6: error: âMEMREMAP_WBâ undeclared (first use in this function)
MEMREMAP_WB);
^~~~~~~~~~~
../sound/hda/intel-nhlt.c:42:6: note: each undeclared identifier is reported only once for each function it appears in
../sound/hda/intel-nhlt.c:45:25: error: dereferencing pointer to incomplete type âstruct nhlt_acpi_tableâ
(strncmp(nhlt_table->header.signature,
^~
../sound/hda/intel-nhlt.c:48:3: error: implicit declaration of function âmemunmapâ; did you mean âvunmapâ? [-Werror=implicit-function-declaration]
memunmap(nhlt_table);
^~~~~~~~
vunmap
../sound/hda/intel-nhlt.c: At top level:
../sound/hda/intel-nhlt.c:56:6: error: redefinition of âintel_nhlt_freeâ
void intel_nhlt_free(struct nhlt_acpi_table *nhlt)
^~~~~~~~~~~~~~~
In file included from ../sound/hda/intel-nhlt.c:5:0:
../include/sound/intel-nhlt.h:139:20: note: previous definition of âintel_nhlt_freeâ was here
static inline void intel_nhlt_free(struct nhlt_acpi_table *addr)
^~~~~~~~~~~~~~~
../sound/hda/intel-nhlt.c:62:5: error: redefinition of âintel_nhlt_get_dmic_geoâ
int intel_nhlt_get_dmic_geo(struct device *dev, struct nhlt_acpi_table *nhlt)
^~~~~~~~~~~~~~~~~~~~~~~
In file included from ../sound/hda/intel-nhlt.c:5:0:
../include/sound/intel-nhlt.h:143:19: note: previous definition of âintel_nhlt_get_dmic_geoâ was here
static inline int intel_nhlt_get_dmic_geo(struct device *dev,
^~~~~~~~~~~~~~~~~~~~~~~
../sound/hda/intel-nhlt.c: In function âintel_nhlt_get_dmic_geoâ:
../sound/hda/intel-nhlt.c:76:11: error: dereferencing pointer to incomplete type âstruct nhlt_endpointâ
if (epnt->linktype == NHLT_LINK_DMIC) {
^~
../sound/hda/intel-nhlt.c:76:25: error: âNHLT_LINK_DMICâ undeclared (first use in this function)
if (epnt->linktype == NHLT_LINK_DMIC) {
^~~~~~~~~~~~~~
../sound/hda/intel-nhlt.c:79:15: error: dereferencing pointer to incomplete type âstruct nhlt_dmic_array_configâ
switch (cfg->array_type) {
^~
../sound/hda/intel-nhlt.c:80:9: error: âNHLT_MIC_ARRAY_2CH_SMALLâ undeclared (first use in this function)
case NHLT_MIC_ARRAY_2CH_SMALL:
^~~~~~~~~~~~~~~~~~~~~~~~
../sound/hda/intel-nhlt.c:81:9: error: âNHLT_MIC_ARRAY_2CH_BIGâ undeclared (first use in this function); did you mean âNHLT_MIC_ARRAY_2CH_SMALLâ?
case NHLT_MIC_ARRAY_2CH_BIG:
^~~~~~~~~~~~~~~~~~~~~~
NHLT_MIC_ARRAY_2CH_SMALL
../sound/hda/intel-nhlt.c:82:16: error: âMIC_ARRAY_2CHâ undeclared (first use in this function); did you mean âNHLT_MIC_ARRAY_2CH_BIGâ?
dmic_geo = MIC_ARRAY_2CH;
^~~~~~~~~~~~~
NHLT_MIC_ARRAY_2CH_BIG
../sound/hda/intel-nhlt.c:85:9: error: âNHLT_MIC_ARRAY_4CH_1ST_GEOMâ undeclared (first use in this function); did you mean âNHLT_MIC_ARRAY_2CH_BIGâ?
case NHLT_MIC_ARRAY_4CH_1ST_GEOM:
^~~~~~~~~~~~~~~~~~~~~~~~~~~
NHLT_MIC_ARRAY_2CH_BIG
../sound/hda/intel-nhlt.c:86:9: error: âNHLT_MIC_ARRAY_4CH_L_SHAPEDâ undeclared (first use in this function); did you mean âNHLT_MIC_ARRAY_4CH_1ST_GEOMâ?
case NHLT_MIC_ARRAY_4CH_L_SHAPED:
^~~~~~~~~~~~~~~~~~~~~~~~~~~
NHLT_MIC_ARRAY_4CH_1ST_GEOM
AR sound/i2c/other/built-in.a
../sound/hda/intel-nhlt.c:87:9: error: âNHLT_MIC_ARRAY_4CH_2ND_GEOMâ undeclared (first use in this function); did you mean âNHLT_MIC_ARRAY_4CH_1ST_GEOMâ?
case NHLT_MIC_ARRAY_4CH_2ND_GEOM:
^~~~~~~~~~~~~~~~~~~~~~~~~~~
NHLT_MIC_ARRAY_4CH_1ST_GEOM
../sound/hda/intel-nhlt.c:88:16: error: âMIC_ARRAY_4CHâ undeclared (first use in this function); did you mean âMIC_ARRAY_2CHâ?
dmic_geo = MIC_ARRAY_4CH;
^~~~~~~~~~~~~
MIC_ARRAY_2CH
AR sound/i2c/built-in.a
CC drivers/bluetooth/btmtksdio.o
../sound/hda/intel-nhlt.c:90:9: error: âNHLT_MIC_ARRAY_VENDOR_DEFINEDâ undeclared (first use in this function); did you mean âNHLT_MIC_ARRAY_4CH_L_SHAPEDâ?
case NHLT_MIC_ARRAY_VENDOR_DEFINED:
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NHLT_MIC_ARRAY_4CH_L_SHAPED
../sound/hda/intel-nhlt.c:92:26: error: dereferencing pointer to incomplete type âstruct nhlt_vendor_dmic_array_configâ
dmic_geo = cfg_vendor->nb_mics;
^~
../sound/hda/intel-nhlt.c: At top level:
../sound/hda/intel-nhlt.c:106:16: error: expected declaration specifiers or â...â before string constant
MODULE_LICENSE("GPL v2");
^~~~~~~~
../sound/hda/intel-nhlt.c:107:20: error: expected declaration specifiers or â...â before string constant
MODULE_DESCRIPTION("Intel NHLT driver");
^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [../scripts/Makefile.build:266: sound/hda/intel-nhlt.o] Error 1

Next message: Valdis KlÄtnieks: "Re: next-20190826 - objtool fails to build."
Previous message: Uwe Kleine-KÃnig: "Re: [PATCH v2] vsprintf: introduce %dE for error constants"
In reply to: Randy Dunlap: "Re: mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c)"
Next in thread: Randy Dunlap: "Re: mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]