[PATCH v2] PCI: hv: Make functions only used locally static in pci-hyperv.c
From: Krzysztof Wilczynski
Date: Wed Aug 28 2019 - 18:18:53 EST
Functions hv_read_config_block(), hv_write_config_block()
and hv_register_block_invalidate() are not used anywhere
else and are local to drivers/pci/controller/pci-hyperv.c,
and do not need to be in global scope, so make these static.
Resolve following compiler warning that can be seen when
building with warnings enabled (W=1):
drivers/pci/controller/pci-hyperv.c:933:5: warning: no previous prototype for âhv_read_config_blockâ [-Wmissing-prototypes]
int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len,
^
drivers/pci/controller/pci-hyperv.c:1013:5: warning: no previous prototype for âhv_write_config_blockâ [-Wmissing-prototypes]
int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len,
^
drivers/pci/controller/pci-hyperv.c:1082:5: warning: no previous prototype for âhv_register_block_invalidateâ [-Wmissing-prototypes]
int hv_register_block_invalidate(struct pci_dev *pdev, void *context,
^
Signed-off-by: Krzysztof Wilczynski <kw@xxxxxxxxx>
---
Changes in v2:
Update commit message to include compiler warning.
drivers/pci/controller/pci-hyperv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
index f1f300218fab..c9642e429c2d 100644
--- a/drivers/pci/controller/pci-hyperv.c
+++ b/drivers/pci/controller/pci-hyperv.c
@@ -930,7 +930,7 @@ static void hv_pci_read_config_compl(void *context, struct pci_response *resp,
*
* Return: 0 on success, -errno on failure
*/
-int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len,
+static int hv_read_config_block(struct pci_dev *pdev, void *buf, unsigned int len,
unsigned int block_id, unsigned int *bytes_returned)
{
struct hv_pcibus_device *hbus =
@@ -1010,7 +1010,7 @@ static void hv_pci_write_config_compl(void *context, struct pci_response *resp,
*
* Return: 0 on success, -errno on failure
*/
-int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len,
+static int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len,
unsigned int block_id)
{
struct hv_pcibus_device *hbus =
@@ -1079,7 +1079,7 @@ int hv_write_config_block(struct pci_dev *pdev, void *buf, unsigned int len,
*
* Return: 0 on success, -errno on failure
*/
-int hv_register_block_invalidate(struct pci_dev *pdev, void *context,
+static int hv_register_block_invalidate(struct pci_dev *pdev, void *context,
void (*block_invalidate)(void *context,
u64 block_mask))
{
--
2.22.1