Re: [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c

From: Krzysztof Wilczynski
Date: Wed Aug 28 2019 - 19:33:56 EST


Hello Bjorn,
Thank you for feedback.

[...]
Maybe just:

PCI: hv: Make functions static

since we already know it's in pci-hyperv.c, and it's obvious that you
can only do this for functions that are only used locally.

Makes sense. I will update the subject line in v3.

[...]
Rewrap commit log to fill 75 columns.

Sorry about this. I wasn't sure if one also should wrap compiler and/or
checkpatch.pl script warnings or errors. I will fix this.

Does this fix all the similar warnings in drivers/pci/? If there are
more, maybe we could fix them all in a single patch or at least a
single series?

At the moment, while compiling the drivers/pci the compiler yields a similar
warning for the following files:

arch/x86/pci/xen.c
arch/x86/pci/numachip.c
drivers/pci/controller/pci-hyperv.c
drivers/pci/vc.c

I will have a look at each closer.

Krzysztof