Re: [PATCH] mtd: hyperbus: fix dependency and build error
From: Miquel Raynal
Date: Thu Aug 29 2019 - 08:36:47 EST
On Tue, 2019-08-13 at 23:03:13 UTC, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> lib/devres.c, which implements devm_ioremap_resource(), is only built
> when CONFIG_HAS_IOMEM is set/enabled, so MTD_HYPERBUS should depend
> on HAS_IOMEM. Fixes a build error and a Kconfig warning (as seen on
> UML builds):
>
> WARNING: unmet direct dependencies detected for MTD_COMPLEX_MAPPINGS
> Depends on [n]: MTD [=m] && HAS_IOMEM [=n]
> Selected by [m]:
> - MTD_HYPERBUS [=m] && MTD [=m]
>
> ERROR: "devm_ioremap_resource" [drivers/mtd/hyperbus/hyperbus-core.ko] undefined!
>
> Fixes: dcc7d3446a0f ("mtd: Add support for HyperBus memory devices")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Vignesh Raghavendra <vigneshr@xxxxxx>
> Cc: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: linux-mtd@xxxxxxxxxxxxxxxxxxx
> Acked-by: Vignesh Raghavendra <vigneshr@xxxxxx>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.
Miquel