Re: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines

From: Vivek Goyal
Date: Thu Aug 29 2019 - 09:29:57 EST


On Thu, Aug 29, 2019 at 11:28:27AM +0200, Miklos Szeredi wrote:
> On Wed, Aug 21, 2019 at 7:38 PM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
> >
> > Hi,
> >
> > Here are the V3 patches for virtio-fs filesystem. This time I have
> > broken the patch series in two parts. This is first part which does
> > not contain DAX support. Second patch series will contain the patches
> > for DAX support.
> >
> > I have also dropped RFC tag from first patch series as we believe its
> > in good enough shape that it should get a consideration for inclusion
> > upstream.
>
> Pushed out to
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#for-next
>

Hi Miklos,

Compilation of virtio-fs as module fails. While it works if compiled as
non-module.

fs/fuse/virtio_fs.c: In function âcopy_args_to_argbufâ:
fs/fuse/virtio_fs.c:255:5: error: âstruct fuse_reqâ has no member named âargbufâ
req->argbuf = kmalloc(len, GFP_ATOMIC);

It can't find req->argbuf.

I noticed that you have put ifdef around argbuf.

#ifdef CONFIG_VIRTIO_FS
/** virtio-fs's physically contiguous buffer for in and out args */
void *argbuf;
#endif

It should have worked. Not sure why it is not working.

Vivek