RE: [PATCH v3] PCI: hv: Make functions static

From: Haiyang Zhang
Date: Thu Aug 29 2019 - 11:51:18 EST




> -----Original Message-----
> From: Krzysztof Wilczynski <kswilczynski@xxxxxxxxx> On Behalf Of Krzysztof
> Wilczynski
> Sent: Thursday, August 29, 2019 2:17 AM
> To: Bjorn Helgaas <helgaas@xxxxxxxxxx>
> Cc: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang
> <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger
> <sthemmin@xxxxxxxxxxxxx>; Sasha Levin <sashal@xxxxxxxxxx>; Lorenzo
> Pieralisi <lorenzo.pieralisi@xxxxxxx>; linux-pci@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-hyperv@xxxxxxxxxxxxxxx
> Subject: [PATCH v3] PCI: hv: Make functions static
>
> Functions hv_read_config_block(), hv_write_config_block() and
> hv_register_block_invalidate() are not used anywhere else and are local to
> drivers/pci/controller/pci-hyperv.c,
> and do not need to be in global scope, so make these static.
>
> Resolve following compiler warning that can be seen when building with
> warnings enabled (W=1):
>
> drivers/pci/controller/pci-hyperv.c:933:5: warning:
> no previous prototype for âhv_read_config_blockâ
> [-Wmissing-prototypes]
>
> drivers/pci/controller/pci-hyperv.c:1013:5: warning:
> no previous prototype for âhv_write_config_blockâ
> [-Wmissing-prototypes]
>
> drivers/pci/controller/pci-hyperv.c:1082:5: warning:
> no previous prototype for âhv_register_block_invalidateâ
> [-Wmissing-prototypes]
>
> Signed-off-by: Krzysztof Wilczynski <kw@xxxxxxxxx>

Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>

Thanks!