Re: [alsa-devel] mmotm 2019-08-27-20-39 uploaded (sound/hda/intel-nhlt.c)
From: Pierre-Louis Bossart
Date: Thu Aug 29 2019 - 12:22:32 EST
On 8/29/19 10:08 AM, Takashi Iwai wrote:
On Thu, 29 Aug 2019 00:45:05 +0200,
Pierre-Louis Bossart wrote:
I just checked with Mark Brown's for-next tree
8aceffa09b4b9867153bfe0ff6f40517240cee12
and things are fine in i386 mode, see below.
next-20190828 also works fine for me in i386 mode.
if you can point me to a tree and configuration that don't work
I'll look into this, I'd need more info to progress.
Please try the attached randconfig file.
Thanks for looking.
Ack, I see some errors as well with this config. Likely a missing
dependency somewhere, working on this now.
My bad, I added a fallback with static inline functions in the .h file
when ACPI is not defined, but the .c file was still compiled.
The diff below makes next-20190828 compile with Randy's config.
IMO, we need to fix the site that enables this config. i.e.
the "select SND_INTEL_NHLT" must be always conditional, e.g.
select SND_INTEL_NHLT if ACPI
that would be nicer indeed, currently we don't have a consistent solution:
sound/pci/hda/Kconfig: select SND_INTEL_NHLT if ACPI
sound/soc/intel/Kconfig: select SND_INTEL_NHLT
sound/soc/sof/intel/Kconfig: select SND_INTEL_NHLT
I can't recall why things are different, will send a patch to align.
It looks like the alsa-devel server is down btw?
Now it seems starting again.
thanks,
Takashi
diff --git a/sound/hda/Makefile b/sound/hda/Makefile
index 8560f6ef1b19..b3af071ce06b 100644
--- a/sound/hda/Makefile
+++ b/sound/hda/Makefile
@@ -14,5 +14,7 @@ obj-$(CONFIG_SND_HDA_CORE) += snd-hda-core.o
#extended hda
obj-$(CONFIG_SND_HDA_EXT_CORE) += ext/
+ifdef CONFIG_ACPI
snd-intel-nhlt-objs := intel-nhlt.o
obj-$(CONFIG_SND_INTEL_NHLT) += snd-intel-nhlt.o
+endif
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel