Re: [PATCH] drm/virtio: Use vmalloc for command buffer allocations.
From: Gerd Hoffmann
Date: Fri Aug 30 2019 - 02:09:06 EST
Hi,
> {
> if (vbuf->resp_size > MAX_INLINE_RESP_SIZE)
> kfree(vbuf->resp_buf);
> - kfree(vbuf->data_buf);
> + kvfree(vbuf->data_buf);
if (is_vmalloc_addr(vbuf->data_buf)) ...
needed here I gues?
> +/* Create sg_table from a vmalloc'd buffer. */
> +static struct sg_table *vmalloc_to_sgt(char *data, uint32_t size)
Hmm, isn't there an existing function for that?
I'd be surprised if virtio-gpu is the first driver needing this ...
And it case there really isn't one this should probably added to the
vmalloc or scatterlist code, not the virtio-gpu driver.
cheers,
Gerd