Re: [PATCH v3 4/7] erofs: kill __packed for on-disk structures

From: Chao Yu
Date: Fri Aug 30 2019 - 02:16:48 EST


On 2019/8/30 11:36, Gao Xiang wrote:
> As Christoph claimed "Please don't add __packed" [1],
> I have to remove all __packed except struct erofs_dirent here.
>
> Note that all on-disk fields except struct erofs_dirent
> (12 bytes with a 8-byte nid) in EROFS are naturally aligned.
>
> [1] https://lore.kernel.org/lkml/20190829095954.GB20598@xxxxxxxxxxxxx/
> Reported-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Signed-off-by: Gao Xiang <gaoxiang25@xxxxxxxxxx>

Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>

Thanks,