Re: [PATCH RESEND v2 4/6] dt-bindings: watchdog: sun4i: Add the watchdog clock

From: Guenter Roeck
Date: Fri Aug 30 2019 - 12:48:44 EST


On Wed, Aug 21, 2019 at 04:38:33PM +0200, Maxime Ripard wrote:
> From: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>
>
> The Allwinner watchdog has a clock that has been described in some DT, but
> not all of them.
>
> The binding is also completely missing that description. Let's add that
> property to be consistent.
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>
>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>
> Changes from v1:
> - New patch
> ---
> .../bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> index 31c95c404619..3a54f58683a0 100644
> --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> @@ -31,12 +31,16 @@ properties:
> reg:
> maxItems: 1
>
> + clocks:
> + maxItems: 1
> +
> interrupts:
> maxItems: 1
>
> required:
> - compatible
> - reg
> + - clocks
> - interrupts
>
> unevaluatedProperties: false
> @@ -47,6 +51,7 @@ examples:
> compatible = "allwinner,sun4i-a10-wdt";
> reg = <0x01c20c90 0x10>;
> interrupts = <24>;
> + clocks = <&osc24M>;
> timeout-sec = <10>;
> };
>
> --
> 2.21.0
>