Re: [PATCH v2 3/3] nvme: fire discovery log page change events to userspace

From: Sagi Grimberg
Date: Fri Aug 30 2019 - 14:08:24 EST



Yes we do, userspace should use it to order events. Does udev not
handle that properly today?

The problem is not ordering of events, its really about the fact that
the chardev can be removed and reallocated for a different controller
(could be a completely different discovery controller) by the time
that userspace handles the event.

The same is generally true for lot of kernel devices. We could reduce
the chance by using the idr cyclic allocator.

Well, it was raised by Hannes and James, so I'll ask them respond here
because I don't mind having it this way. I personally think that this
is a better approach than having a cyclic idr allocator. In general, I
don't necessarily think that this is a good idea to have cyclic
controller enumerations if we don't absolutely have to...