Re: linux-next: build failure after merge of the pci tree
From: Lorenzo Pieralisi
Date: Sat Aug 31 2019 - 04:49:34 EST
On Sat, Aug 31, 2019 at 09:51:05AM +0530, Vidya Sagar wrote:
> On 8/30/2019 6:00 PM, Bjorn Helgaas wrote:
> > [+cc Krzysztof]
> >
> > On Thu, Aug 29, 2019 at 10:23 PM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> > >
> > > Hi all,
> > >
> > > After merging the pci tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > >
> > > drivers/pci/controller/dwc/pcie-tegra194.c:24:10: fatal error: linux/pci-aspm.h: No such file or directory
> > > 24 | #include <linux/pci-aspm.h>
> > > | ^~~~~~~~~~~~~~~~~~
> > >
> > > Caused by commit
> > >
> > > 81564976b1a9 ("PCI: tegra: Add Tegra194 PCIe support")
> > >
> > > I have reverted that commit for todat.
> >
> > Thanks, Stephen.
> >
> > I *could* fix this by removing that include in the merge, since the
> > contents of linux/pci-aspm.h were moved into linux/pci.h by
> > https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=7ce2e76a0420
> >
> > But as far as I can tell, pcie-tegra194.c doesn't actually require
> > anything from linux/pci-aspm.h, so I'd rather amend the tegra194
> > commit https://git.kernel.org/cgit/linux/kernel/git/lpieralisi/pci.git/commit/?id=81564976b1a9
> > so it doesn't include pci-aspm.h in the first place.
> Thanks Bjorn for the reply.
> Yes. This header file is not required for now and can be removed.
> Is there any action required from my side for this?
I updated my pci/tegra branch so that Bjorn can pull it.
Lorenzo