Re: [PATCH] tpm: Remove duplicate code from caps_show() in tpm-sysfs.c

[Jarkko Sakkinen]

On Fri, Aug 30, 2019 at 09:09:02AM -0700, Jerry Snitselaar wrote:
> On Thu Aug 29 19, Jarkko Sakkinen wrote:
> +	/* TPM 1.1 */
> > +	if (tpm1_getcap(chip, TPM_CAP_VERSION_1_1, &cap,
> > +			"attempting to determine the 1.1 version",
> > +			sizeof(cap.version1))) {
> > +		version = &cap.version1;
:> 
> Actually looking at this again, this seems wrong. The version
> assignment here should be below this if, or in an else block, yes?

Absolutely is in a wrong place.

I sent an updated patch:

https://patchwork.kernel.org/patch/11126741/

/Jarkko