[PATCH] extcon: axp288: Variable "val" could be uninitialized if regmap_read() fails

From: Yizhuo
Date: Mon Sep 02 2019 - 18:41:02 EST


In function axp288_extcon_log_rsi(), variable "val" could be
uninitialized if regmap_read() fails. However, it's ued to
decide the control flow later in the if statement, which is
potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@xxxxxxx>
---
drivers/extcon/extcon-axp288.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
index 7254852e6ec0..54116a926ab6 100644
--- a/drivers/extcon/extcon-axp288.c
+++ b/drivers/extcon/extcon-axp288.c
@@ -135,6 +135,11 @@ static void axp288_extcon_log_rsi(struct axp288_extcon_info *info)
int ret;

ret = regmap_read(info->regmap, AXP288_PS_BOOT_REASON_REG, &val);
+ if (ret) {
+ dev_err(info->dev, "failed to read AXP288_PS_BOOT_REASON_REG\n");
+ return;
+ }
+
for (i = 0, rsi = axp288_pwr_up_down_info; *rsi; rsi++, i++) {
if (val & BIT(i)) {
dev_dbg(info->dev, "%s\n", *rsi);
--
2.17.1