Re: [PATCH v4 4/5] HID: hv: Remove dependencies on PAGE_SIZE for ring buffer

From: Sasha Levin
Date: Mon Sep 02 2019 - 20:26:58 EST


On Mon, Sep 02, 2019 at 01:30:44PM +0200, Jiri Kosina wrote:
On Sat, 31 Aug 2019, Michael Kelley wrote:

From: Maya Nakamura <m.maya.nakamura@xxxxxxxxx> Sent: Friday, July 12, 2019 1:28 AM
>
> Define the ring buffer size as a constant expression because it should
> not depend on the guest page size.
>
> Signed-off-by: Maya Nakamura <m.maya.nakamura@xxxxxxxxx>
> Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>

Jiri and Benjamin -- OK if this small patch for the Hyper-V HID driver
goes through the Hyper-V tree maintained by Sasha Levin? It's a purely
Hyper-V change so the ring buffer size isn't bigger when running
on ARM64 where the page size might be 16K or 64K.

Yeah; FWIW feel free to add

Acked-by: Jiri Kosina <jkosina@xxxxxxx>

Queued up for hyperv-next, thanks!

--
Thanks,
Sasha