Re: [PATCH v3 4/4] edac: Add support for Amazon's Annapurna Labs L2 EDAC

[Hawa, Hanna]

On 9/3/2019 10:27 AM, Robert Richter wrote:
> On 15.07.19 16:24:09, Hanna Hawa wrote:
> > Adds support for Amazon's Annapurna Labs L2 EDAC driver to detect and
> > report L2 errors.
> >
> > Signed-off-by: Hanna Hawa <hhhawa@xxxxxxxxxx>
> > ---
> >   MAINTAINERS               |   6 ++
> >   drivers/edac/Kconfig      |   8 ++
> >   drivers/edac/Makefile     |   1 +
> >   drivers/edac/al_l2_edac.c | 187 ++++++++++++++++++++++++++++++++++++++++++++++
> >   4 files changed, 202 insertions(+)
> >   create mode 100644 drivers/edac/al_l2_edac.c
>
>  From a brief look at it, it seems some of my comments from 2/4 apply
> here too. Please look through it.

Thanks for your review, will look and fix on top of v5.

Thanks,
Hanna

> -Robert