Re: [PATCH v2 1/8] arm64: compat: vdso: Expose BUILD_VDSO32

From: Vincenzo Frascino
Date: Tue Sep 03 2019 - 10:34:48 EST


Hi Catalin and Will,

On 8/30/19 2:58 PM, Vincenzo Frascino wrote:
> clock_gettime32 and clock_getres_time32 should be compiled only with the
> 32 bit vdso library.
>
> Expose BUILD_VDSO32 when arm64 compat is compiled, to provide an
> indication to the generic library to include these symbols.
>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Will Deacon <will@xxxxxxxxxx>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>
> Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> ---
> arch/arm64/include/asm/vdso/compat_gettimeofday.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/include/asm/vdso/compat_gettimeofday.h b/arch/arm64/include/asm/vdso/compat_gettimeofday.h
> index c50ee1b7d5cd..fe7afe0f1a3d 100644
> --- a/arch/arm64/include/asm/vdso/compat_gettimeofday.h
> +++ b/arch/arm64/include/asm/vdso/compat_gettimeofday.h
> @@ -17,6 +17,7 @@
> #define VDSO_HAS_CLOCK_GETRES 1
>
> #define VDSO_HAS_32BIT_FALLBACK 1
> +#define BUILD_VDSO32 1
>
> static __always_inline
> int gettimeofday_fallback(struct __kernel_old_timeval *_tv,
>

This patch is independent from the rest and touches only arch code. Can it go in
via the arm64 tree?

--
Regards,
Vincenzo