Re: [PATCH v2 1/4] x86/mm: Export force_dma_unencrypted

From: Christoph Hellwig
Date: Tue Sep 03 2019 - 12:22:12 EST


On Tue, Sep 03, 2019 at 04:32:45PM +0200, Thomas Hellström (VMware) wrote:
> Is this a layer violation concern, that is, would you be ok with a similar
> helper for TTM, or is it that you want to force the graphics drivers into
> adhering strictly to the DMA api, even when it from an engineering
> perspective makes no sense?

>From looking at DRM I strongly believe that making DRM use the DMA
mapping properly makes a lot of sense from the engineering perspective,
and this series is a good argument for that positions. If DRM was using
the DMA properl we would not need this series to start with, all the
SEV handling is hidden behind the DMA API. While we had occasional
bugs in that support fixing it meant that it covered all drivers
properly using that API.