Re: [PATCH v2 0/3] soc: qcom: llcc cleanups

From: Bjorn Andersson
Date: Wed Sep 04 2019 - 00:43:02 EST


On Tue 27 Aug 04:01 PDT 2019, Vivek Gautam wrote:

> On Fri, Aug 2, 2019 at 11:43 AM Vivek Gautam
> <vivek.gautam@xxxxxxxxxxxxxx> wrote:
> >
> > On Thu, Jul 18, 2019 at 6:33 PM Vivek Gautam
> > <vivek.gautam@xxxxxxxxxxxxxx> wrote:
> > >
> > > To better support future versions of llcc, consolidating the
> > > driver to llcc-qcom driver file, and taking care of the dependencies.
> > > v1 series is availale at:
> > > https://lore.kernel.org/patchwork/patch/1099573/
> > >
> > > Changes since v1:
> > > Addressing Bjorn's comments -
> > > * Not using llcc-plat as the platform driver rather using a single
> > > driver file now - llcc-qcom.
> > > * Removed SCT_ENTRY macro.
> > > * Moved few structure definitions from include/linux path to llcc-qcom
> > > driver as they are not exposed to other subsystems.
> >
> > Hi Bjorn,
> >
> > How does this cleanup look now? Let me know if there are any
> > improvements to make here.
> >
>
> Hi Bjorn,
>
> Are you planning to pull this series in the next merge window?
> There's a dt patch as well for llcc on sdm845 [1] that has been lying around.
>
> Let me know if you have concerns with this series. I will be happy to
> incorporate the suggestions.
>

No concerns, this is exactly what we discussed before. Sorry for missing
it. I've picked the patches now.

> [1] https://lore.kernel.org/patchwork/patch/1099318/
>

This is part of the v5.4 pull request.

Thanks,
Bjorn

> Thanks & Regards
> Vivek
>
> > Best Regards
> > Vivek
> > >
> > > Vivek Gautam (3):
> > > soc: qcom: llcc cleanup to get rid of sdm845 specific driver file
> > > soc: qcom: Rename llcc-slice to llcc-qcom
> > > soc: qcom: Make llcc-qcom a generic driver
> > >
> > > drivers/soc/qcom/Kconfig | 14 +--
> > > drivers/soc/qcom/Makefile | 3 +-
> > > drivers/soc/qcom/{llcc-slice.c => llcc-qcom.c} | 155 +++++++++++++++++++++++--
> > > drivers/soc/qcom/llcc-sdm845.c | 100 ----------------
> > > include/linux/soc/qcom/llcc-qcom.h | 104 -----------------
> > > 5 files changed, 152 insertions(+), 224 deletions(-)
> > > rename drivers/soc/qcom/{llcc-slice.c => llcc-qcom.c} (64%)
> > > delete mode 100644 drivers/soc/qcom/llcc-sdm845.c
> > >
>
>
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation