Re: [PATCH] ioat/dca: Use struct_size() helper
From: Vinod Koul
Date: Wed Sep 04 2019 - 00:49:34 EST
On 28-08-19, 13:40, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>
> struct ioat_dca_priv {
> ...
> struct ioat_dca_slot req_slots[0];
> };
>
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes.
>
> So, replace the following form:
>
> sizeof(*ioatdca) + (sizeof(struct ioat_dca_slot) * slots)
>
> with:
>
> struct_size(ioatdca, req_slots, slots)
>
> This code was detected with the help of Coccinelle.
Please do not invent subsystem tags, git log should tell you the
convention to be used!
Applied after fixing tags, thanks
--
~Vinod