Re: [PATCH] soundwire: slave: Fix unused function warning on !ACPI

[Vinod Koul]

On 04-09-19, 12:48, Michal SuchÃnek wrote:
> On Wed, 4 Sep 2019 15:00:52 +0530
> Vinod Koul <vkoul@xxxxxxxxxx> wrote:
> 
> > On 30-08-19, 11:56, Randy Dunlap wrote:
> > > On 8/30/19 11:52 AM, Michal Suchanek wrote:  
> > > > Fixes the following warning on !ACPI systems:
> > > > 
> > > > drivers/soundwire/slave.c:16:12: warning: âsdw_slave_addâ defined but
> > > > not used [-Wunused-function]
> > > >  static int sdw_slave_add(struct sdw_bus *bus,
> > > >             ^~~~~~~~~~~~~
> > > > 
> > > > Signed-off-by: Michal Suchanek <msuchanek@xxxxxxx>  
> > > 
> > > Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > > 
> > > I was about to send the same patch.  
> > 
> > So I have applied Srini's patches which add DT support and they use
> > sdw_slave_add(). So next tomorrow should not see this error as it is now
> > used by DT parts as well.
> > 
> > So dropping this patch
> > 
> 
> That should fix the issue for me. I wonder if !ACPI !DT platforms are
> still a thing.

Heh that should trigger this if we have one :D so should a lot more
which depend on some firmware!

-- 
~Vinod