Re: [PATCH v3 1/2] w1: add 1-wire master driver for IP block found in SGI ASICs

[Greg Kroah-Hartman]

On Wed, Sep 04, 2019 at 02:14:34PM +0200, Thomas Bogendoerfer wrote:
> On Wed, 4 Sep 2019 14:06:46 +0200
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Wed, Sep 04, 2019 at 02:01:34PM +0200, Thomas Bogendoerfer wrote:
> > > On Wed, 4 Sep 2019 13:48:37 +0200
> > > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > 
> > > > On Sat, Aug 31, 2019 at 10:26:21AM +0200, Thomas Bogendoerfer wrote:
> > > > > Starting with SGI Origin machines nearly every new SGI ASIC contains
> > > > > an 1-Wire master. They are used for attaching One-Wire prom devices,
> > > > > which contain information about part numbers, revision numbers,
> > > > > serial number etc. and MAC addresses for ethernet interfaces.
> > > > > This patch adds a master driver to support this IP block.
> > > > > It also adds an extra field dev_id to struct w1_bus_master, which
> > > > > could be in used in slave drivers for creating unique device names.
> > > > > 
> > > > > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@xxxxxxx>
> > > > > ---
> > > > >  drivers/w1/masters/Kconfig           |   9 +++
> > > > >  drivers/w1/masters/Makefile          |   1 +
> > > > >  drivers/w1/masters/sgi_w1.c          | 130 +++++++++++++++++++++++++++++++++++
> > > > >  include/linux/platform_data/sgi-w1.h |  13 ++++
> > > > 
> > > > Why platform data?  I thought that was the "old way", and the "proper
> > > > way" now is to use device tree?
> > > 
> > > this machine is old and doesn't have device tree at all.
> > 
> > Your text says "every new SGI ASIC".  So new devices are being made for
> > old systems?
> > 
> > confused,
> 
> ok, now I see where the confusion comes from. New in the meaning of latest
> produced SGI MIPS system.
> 
> Is it better, if I rephrase this to latest line of MIPS system ASICs ?

Nah, I'll take this now, it's ok, thanks for the explanation.

greg k-h