Re: [RESEND PATCH 0/5] Add bluetooth support for Orange Pi 3

From: Marcel Holtmann
Date: Wed Sep 04 2019 - 10:19:42 EST


Hi Maxime,

>>>>> (Resend to add missing lists, sorry for the noise.)
>>>>>
>>>>> This series implements bluetooth support for Xunlong Orange Pi 3 board.
>>>>>
>>>>> The board uses AP6256 WiFi/BT 5.0 chip.
>>>>>
>>>>> Summary of changes:
>>>>>
>>>>> - add more delay to let initialize the chip
>>>>> - let the kernel detect firmware file path
>>>>> - add new compatible and update dt-bindings
>>>>> - update Orange Pi 3 / H6 DTS
>>>>>
>>>>> Please take a look.
>>>>>
>>>>> thank you and regards,
>>>>> Ondrej Jirman
>>>>>
>>>>> Ondrej Jirman (5):
>>>>> dt-bindings: net: Add compatible for BCM4345C5 bluetooth device
>>>>> bluetooth: bcm: Add support for loading firmware for BCM4345C5
>>>>> bluetooth: hci_bcm: Give more time to come out of reset
>>>>> arm64: dts: allwinner: h6: Add pin configs for uart1
>>>>> arm64: dts: allwinner: orange-pi-3: Enable UART1 / Bluetooth
>>>>>
>>>>> .../bindings/net/broadcom-bluetooth.txt | 1 +
>>>>> .../dts/allwinner/sun50i-h6-orangepi-3.dts | 19 +++++++++++++++++++
>>>>> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 10 ++++++++++
>>>>> drivers/bluetooth/btbcm.c | 3 +++
>>>>> drivers/bluetooth/hci_bcm.c | 3 ++-
>>>>> 5 files changed, 35 insertions(+), 1 deletion(-)
>>>>
>>>> all 5 patches have been applied to bluetooth-next tree.
>>>
>>> The DTS patches (last 2) should go through the arm-soc tree, can you
>>> drop them?
>>
>> why is that? We have included DTS changes for Bluetooth devices
>> directly all the time. What is different with this hardware?
>
> I guess some maintainers are more relaxed with it than we are then,
> but for the why, well, it's the usual reasons, the most immediate one
> being that it reduces to a minimum the conflicts between trees.
>
> The other being that it's not really usual to merge patches supposed
> to be handled by another maintainer without (at least) his
> consent. I'm pretty sure you would have asked the same request if I
> would have merged the bluetooth patches through my tree without
> notice.

I took the two DTS patches out now and let the submitter deal with getting these merged.

Regards

Marcel