Re: [PATCH 1/1] s390: vfio-ap: fix warning reset not completed

[Tony Krowiak]

On 9/3/19 12:45 PM, Cornelia Huck wrote:
> On Tue,  3 Sep 2019 15:36:18 +0200
> Halil Pasic <pasic@xxxxxxxxxxxxx> wrote:
>
> "fix warning for not completed reset"?
>
> > The intention seems to be to warn once when we don't wait enough for the
> > reset to complete. Let's use the right retry counter to accomplish that
> > semantic.
> >
> > Signed-off-by: Halil Pasic <pasic@xxxxxxxxxxxxx>
> > ---
> >   drivers/s390/crypto/vfio_ap_ops.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
> > index 0604b49a4d32..5c0f53c6dde7 100644
> > --- a/drivers/s390/crypto/vfio_ap_ops.c
> > +++ b/drivers/s390/crypto/vfio_ap_ops.c
> > @@ -1143,7 +1143,7 @@ int vfio_ap_mdev_reset_queue(unsigned int apid, unsigned int apqi,
> >   				msleep(20);
> >   				status = ap_tapq(apqn, NULL);
> >   			}
> > -			WARN_ON_ONCE(retry <= 0);
> > +			WARN_ON_ONCE(retry2 <= 0);
> >   			return 0;
> >   		case AP_RESPONSE_RESET_IN_PROGRESS:
> >   		case AP_RESPONSE_BUSY:
>
> Makes sense.
>
> Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>

Agreed:
Reviewed-by: Tony Krowiak <akrowiak@xxxxxxxxxxxxx>
>