Re: [PATCH v5 11/11] lib/test_printf: Add tests for %pfw printk modifier

[Andy Shevchenko]

On Wed, Sep 04, 2019 at 07:10:51PM +0300, Sakari Ailus wrote:
> On Mon, Sep 02, 2019 at 07:13:52PM +0300, Andy Shevchenko wrote:
> > On Mon, Sep 02, 2019 at 04:57:32PM +0300, Sakari Ailus wrote:
> > > Add a test for the %pfw printk modifier using software nodes.
> > 
> > > +static void __init fwnode_pointer(void)
> > > +{
> > > +	const struct software_node softnodes[] = {
> > > +		{ .name = "first", },
> > > +		{ .name = "second", .parent = &softnodes[0], },
> > > +		{ .name = "third", .parent = &softnodes[1], },
> > > +		{ NULL /* Guardian */ },
> > 
> > Comma is still here :-)
> 
> Oops. I ended up removing the comma in a wrong patch which wasn't submitted
> to the list. Will fix for v6.

Also you may remove NULL there since it's default.

-- 
With Best Regards,
Andy Shevchenko