Re: [PATCH] media: siano: Use the correct style for SPDX License Identifier

[Mauro Carvalho Chehab]

Em Sat, 31 Aug 2019 20:41:51 +0530
Nishad Kamdar <nishadkamdar@xxxxxxxxx> escreveu:

> This patch corrects the SPDX License Identifier style
> in header file related to Siano Mobile Silicon Digital TV.
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used)
> 
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46
> 
> Suggested-by: Joe Perches <joe@xxxxxxxxxxx>
> Signed-off-by: Nishad Kamdar <nishadkamdar@xxxxxxxxx>
> ---
>  drivers/media/common/siano/smsir.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/common/siano/smsir.h b/drivers/media/common/siano/smsir.h
> index b2c54c256e86..ada41d5c4e83 100644
> --- a/drivers/media/common/siano/smsir.h
> +++ b/drivers/media/common/siano/smsir.h
> @@ -1,5 +1,5 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
>  /*
> - * SPDX-License-Identifier: GPL-2.0+
>   *
>   * Siano Mobile Silicon, Inc.
>   * MDTV receiver kernel modules.

What's wrong with that? The above is a perfectly fine SPDX header.

Thanks,
Mauro