Re: [PATCH] media: siano: Use the correct style for SPDX License Identifier

From: Joe Perches
Date: Wed Sep 04 2019 - 15:26:52 EST


On Wed, 2019-09-04 at 16:00 -0300, Mauro Carvalho Chehab wrote:
> With Python, you can't even use the second line, as it is reserved
> for charset encoding.
>
> So, realistically, the SPDX header could be up to the third line of
> a given file.
>
> Besides that, I vaguely remember some discussions we had, back on the
> days SPDX was introduced, envolving Thomas, Linus and others. My
> understanding for such discussions is that something like this:
>
> /*
> * SPDX-License-Identifier: GPL-2.0+
> *
> * some other notes about the file
> */
>
> Would be acceptable, as the first line of the comment (with is at
> the beginning of the file) is the SPDX tag.

Using the 2nd line of a .[ch] file does not follow the
documented mechanisms.

Documentation/process/license-rules.rst-1. Placement:
Documentation/process/license-rules.rst-
Documentation/process/license-rules.rst- The SPDX license identifier in kernel files shall be added at the first
Documentation/process/license-rules.rst: possible line in a file which can contain a comment. For the majority
Documentation/process/license-rules.rst: of files this is the first line, except for scripts which require the
Documentation/process/license-rules.rst: '#!PATH_TO_INTERPRETER' in the first line. For those scripts the SPDX
Documentation/process/license-rules.rst: identifier goes into the second line.