Re: [PATCH 1/1] x86/purgatory: Change compiler flags to avoid relocation errors.

From: Nick Desaulniers
Date: Wed Sep 04 2019 - 20:23:40 EST


On Wed, Sep 4, 2019 at 5:19 PM 'Vaibhav Rustagi' via Clang Built Linux
<clang-built-linux@xxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Sep 4, 2019 at 3:28 PM Vaibhav Rustagi
> <vaibhavrustagi@xxxxxxxxxx> wrote:
> >
> > On Wed, Sep 4, 2019 at 3:19 PM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote:
> > > Vaibhav, do you still have an environment setup to quickly test this
> > > again w/ Clang builds?
> >
> > I will setup the environment and will try the changes.
> >
> I tried the changes and kdump was working.
>

Great! Thanks for your help confirming the fix. If you put your
"tested by tag" next time it may help some maintainers who use
automation to collect patches. That way your help is immortalized in
the source! Such a response would look like:

Tested-by: Vaibhav Rustagi <vaibhavrustagi@xxxxxxxxxx>

(see other patches in `git log`)
--
Thanks again,
~Nick Desaulniers