RE: [EXT] [PATCH] net: qed: Move static keyword to the front of declaration

[Michal Kalderon]

> From: Krzysztof Wilczynski <kswilczynski@xxxxxxxxx> On Behalf Of Krzysztof
> Wilczynski
> 
> External Email
> 
> ----------------------------------------------------------------------
> Move the static keyword to the front of declaration of iwarp_state_names,
> and resolve the following compiler warning that can be seen when building
> with warnings enabled (W=1):
> 
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c:385:1: warning:
>   âstaticâ is not at beginning of declaration [-Wold-style-declaration]
> 
> Also, resolve checkpatch.pl script warning:
> 
> WARNING: static const char * array should probably be
>   static const char * const
> 
> Signed-off-by: Krzysztof Wilczynski <kw@xxxxxxxxx>
> ---
> Related: https://lore.kernel.org/r/20190827233017.GK9987@xxxxxxxxxx
> 
>  drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> index f380fae8799d..65ec16a31658 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> @@ -382,7 +382,7 @@ qed_iwarp2roce_state(enum qed_iwarp_qp_state
> state)
>  	}
>  }
> 
> -const static char *iwarp_state_names[] = {
> +static const char * const iwarp_state_names[] = {
>  	"IDLE",
>  	"RTS",
>  	"TERMINATE",

Thanks,Â

Acked-by: Michal KalderonÂ<michal.kalderon@xxxxxxxxxxx>


> --
> 2.22.1