Re: [PATCH v2 5/5] misc: fastrpc: free dma buf scatter list

From: Srinivas Kandagatla
Date: Thu Sep 05 2019 - 04:15:45 EST




On 05/09/2019 06:11, Stephen Boyd wrote:
Quoting Srinivas Kandagatla (2019-08-29 02:29:26)
diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index eee2bb398947..47ae84afac2e 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -550,6 +550,7 @@ static void fastrpc_dma_buf_detatch(struct dma_buf *dmabuf,

Is the function really called buf_detatch? Is it supposed to be
buf_detach?

Thanks Stephen, for you keen observation on the spelling, I will send a patch to fix that!

Looks like I inherited that from drivers/staging/android/ion/ion.c

--srini


mutex_lock(&buffer->lock);
list_del(&a->node);
mutex_unlock(&buffer->lock);
+ sg_free_table(&a->sgt);
kfree(a);