Re: [PATCH net] ipv4: fix ifa_flags reuse problem in using ifconfig tool

[David Miller]

From: Su Yanjun <suyj.fnst@xxxxxxxxxxxxxx>
Date: Wed, 4 Sep 2019 15:37:47 +0800

> When NetworkManager has already set ipv4 address then uses
> ifconfig set another ipv4 address. It will use previous ifa_flags
> that will cause device route not be inserted.
> 
> As NetworkManager has already support IFA_F_NOPREFIXROUTE flag [1],
> but ifconfig will reuse the ifa_flags. It's weird especially
> some old scripts or program [2]  still  use ifconfig.
> 
> [1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/
> commit/fec80e7473ad16979af75ed299d68103e7aa3fe9
> 
> [2] LTP or TAHI
> 
> Signed-off-by: Su Yanjun <suyj.fnst@xxxxxxxxxxxxxx>

I don't know about this.

This will lose things like IFA_F_SECONDARY as well.

Sorry, I am not convinced that this change is correct nor safe.