Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver
From: Christoph Hellwig
Date: Thu Sep 05 2019 - 07:26:15 EST
On Thu, Sep 05, 2019 at 11:45:18AM +0100, Andrew Murray wrote:
> > + depends on OF
> > + select PCIE_DW_HOST
> > + help
> > + Say 'Y' here to enable support for Intel AHB/AXI PCIe Host
> > + controller driver.
> > + The Intel PCIe controller is based on the Synopsys Designware
> > + pcie core and therefore uses the Designware core functions to
> > + implement the driver.
>
> I can see this description is similar to others in the same Kconfig,
> however I'm not sure what value a user gains by knowing implementation
> details - it's helpful to know that PCIE_INTEL_AXI is based on the
> Designware core, but is it helpful to know that the Designware core
> functions are used?
Not really. What would be extremely useful for a user is what Intel
SOC contains this IP block, or the fact that most of those were
actually produced by Lantiq, a company bought by Intel.