Re: [PATCH] i2c: muxes: pca9541: use BIT() macro

[Guenter Roeck]

On 9/5/19 6:13 AM, Saiyam Doshi wrote:
> Use bit mask macro BIT() for definition where appropriate.
>
> Signed-off-by: Saiyam Doshi <saiyamdoshi.in@xxxxxxxxx>

linux/bitops.h should be included when using BIT().

Guenter

> ---
>   drivers/i2c/muxes/i2c-mux-pca9541.c | 28 ++++++++++++++--------------
>   1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
> index 9e75d6b9140b..bd4cf8341a06 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca9541.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
> @@ -43,20 +43,20 @@
>   #define PCA9541_CONTROL		0x01
>   #define PCA9541_ISTAT		0x02
>   
> -#define PCA9541_CTL_MYBUS	(1 << 0)
> -#define PCA9541_CTL_NMYBUS	(1 << 1)
> -#define PCA9541_CTL_BUSON	(1 << 2)
> -#define PCA9541_CTL_NBUSON	(1 << 3)
> -#define PCA9541_CTL_BUSINIT	(1 << 4)
> -#define PCA9541_CTL_TESTON	(1 << 6)
> -#define PCA9541_CTL_NTESTON	(1 << 7)
> -
> -#define PCA9541_ISTAT_INTIN	(1 << 0)
> -#define PCA9541_ISTAT_BUSINIT	(1 << 1)
> -#define PCA9541_ISTAT_BUSOK	(1 << 2)
> -#define PCA9541_ISTAT_BUSLOST	(1 << 3)
> -#define PCA9541_ISTAT_MYTEST	(1 << 6)
> -#define PCA9541_ISTAT_NMYTEST	(1 << 7)
> +#define PCA9541_CTL_MYBUS	BIT(0)
> +#define PCA9541_CTL_NMYBUS	BIT(1)
> +#define PCA9541_CTL_BUSON	BIT(2)
> +#define PCA9541_CTL_NBUSON	BIT(3)
> +#define PCA9541_CTL_BUSINIT	BIT(4)
> +#define PCA9541_CTL_TESTON	BIT(6)
> +#define PCA9541_CTL_NTESTON	BIT(7)
> +
> +#define PCA9541_ISTAT_INTIN	BIT(0)
> +#define PCA9541_ISTAT_BUSINIT	BIT(1)
> +#define PCA9541_ISTAT_BUSOK	BIT(2)
> +#define PCA9541_ISTAT_BUSLOST	BIT(3)
> +#define PCA9541_ISTAT_MYTEST	BIT(6)
> +#define PCA9541_ISTAT_NMYTEST	BIT(7)
>   
>   #define BUSON		(PCA9541_CTL_BUSON | PCA9541_CTL_NBUSON)
>   #define MYBUS		(PCA9541_CTL_MYBUS | PCA9541_CTL_NMYBUS)