Re: [PATCH] bus: ti-sysc: Fix clock handling for no-idle quirks

[Grygorii Strashko]

On 05/09/2019 17:03, Tony Lindgren wrote:
> NFSroot can fail on dra7 when cpsw is probed using ti-sysc interconnect
> target module driver as reported by Keerthy.
>
> Device clocks and the interconnect target module may or may not be
> enabled by the bootloader on init, but we currently assume the clocks
> and module are on from the bootloader for "ti,no-idle" and
> "ti,no-idle-on-init" quirks as reported by Grygorii Strashko.
>
> Let's fix the issue by always enabling clocks init, and
> never disable them for "ti,no-idle" quirk. For "ti,no-idle-on-init"
> quirk, we must decrement the usage count later on to allow PM
> runtime to idle the module if requested.
>
> Fixes: 1a5cd7c23cc5 ("bus: ti-sysc: Enable all clocks directly during init to read revision")
> Cc: Keerthy <j-keerthy@xxxxxx>
> Cc: Vignesh Raghavendra <vigneshr@xxxxxx>
> Reported-by: Keerthy <j-keerthy@xxxxxx>
> Reported-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> ---
>   drivers/bus/ti-sysc.c | 48 +++++++++++++++++++++++++++++++++----------
>   1 file changed, 37 insertions(+), 11 deletions(-)

Reviewed-by: Grygorii Strashko <grygorii.strashko@xxxxxx>

Thank you, Tony.

--
Best regards,
grygorii