Re: [PATCH v4] libnvdimm: Enable unit test infrastructure compile checks

[Jason Gunthorpe]

On Wed, Sep 04, 2019 at 03:43:31PM -0700, Dan Williams wrote:
> The infrastructure to mock core libnvdimm routines for unit testing
> purposes is prone to bitrot relative to refactoring of that core.
> Arrange for the unit test core to be built when CONFIG_COMPILE_TEST=y.
> This does not result in a functional unit test environment, it is only a
> helper for 0day to catch unit test build regressions.
> 
> Note that there are a few x86isms in the implementation, so this does
> not bother compile testing this architectures other than 64-bit x86.
> 
> Cc: JÃrÃme Glisse <jglisse@xxxxxxxxxx>
> Cc: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> Reported-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> Link: https://lore.kernel.org/r/156097224232.1086847.9463861924683372741.stgit@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Changes since v3:
> 
> - Switch the Makefile operator from := to += to make sure the unit test
>   infrastructure is incrementally included.
> 
> Jason, lets try this again. This seems to resolve the build error for
> me. I believe ":=" would have intermittent results in a parallel build
> and sometimes result in other targets in drivers/nvdimm/Makefile being
> bypassed. This has been exposed to the 0day robot for a day with no
> reports.

Okay, again we go

Jason