[tip: x86/platform] x86/platform/uv: Fix kmalloc() NULL check routine

[tip-bot2 for Austin Kim]

The following commit has been merged into the x86/platform branch of tip:

Commit-ID:     864b23f0169d5bff677e8443a7a90dfd6b090afc
Gitweb:        https://git.kernel.org/tip/864b23f0169d5bff677e8443a7a90dfd6b090afc
Author:        Austin Kim <austindh.kim@xxxxxxxxx>
AuthorDate:    Fri, 06 Sep 2019 08:29:51 +09:00
Committer:     Ingo Molnar <mingo@xxxxxxxxxx>
CommitterDate: Fri, 06 Sep 2019 07:36:16 +02:00

x86/platform/uv: Fix kmalloc() NULL check routine

The result of kmalloc() should have been checked ahead of below statement:

	pqp = (struct bau_pq_entry *)vp;

Move BUG_ON(!vp) before above statement.

Signed-off-by: Austin Kim <austindh.kim@xxxxxxxxx>
Cc: Dimitri Sivanich <dimitri.sivanich@xxxxxxx>
Cc: Hedi Berriche <hedi.berriche@xxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: Mike Travis <mike.travis@xxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Russ Anderson <russ.anderson@xxxxxxx>
Cc: Steve Wahl <steve.wahl@xxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: allison@xxxxxxxxxxx
Cc: andy@xxxxxxxxxxxxx
Cc: armijn@xxxxxxxxxx
Cc: bp@xxxxxxxxx
Cc: dvhart@xxxxxxxxxxxxx
Cc: gregkh@xxxxxxxxxxxxxxxxxxx
Cc: hpa@xxxxxxxxx
Cc: kjlu@xxxxxxx
Cc: platform-driver-x86@xxxxxxxxxxxxxxx
Link: 20190905232951.GA28779@LGEARND20B15">https://lkml.kernel.org/r/20190905232951.GA28779@LGEARND20B15
Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
---
 arch/x86/platform/uv/tlb_uv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
index 20c389a..5f0a96b 100644
--- a/arch/x86/platform/uv/tlb_uv.c
+++ b/arch/x86/platform/uv/tlb_uv.c
@@ -1804,9 +1804,9 @@ static void pq_init(int node, int pnode)
 
 	plsize = (DEST_Q_SIZE + 1) * sizeof(struct bau_pq_entry);
 	vp = kmalloc_node(plsize, GFP_KERNEL, node);
-	pqp = (struct bau_pq_entry *)vp;
-	BUG_ON(!pqp);
+	BUG_ON(!vp);
 
+	pqp = (struct bau_pq_entry *)vp;
 	cp = (char *)pqp + 31;
 	pqp = (struct bau_pq_entry *)(((unsigned long)cp >> 5) << 5);